Avoid throwing errors when popup container is undefined (#9433) (#9434)

mapbox · Mar 18, 2020 · 251afac · 251afac
1 parent 68c6102
commit 251afac
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/ui/popup.js b/src/ui/popup.js
@@ -309,7 +309,7 @@ export default class Popup extends Evented {
  * @returns {string} The maximum width of the popup.
  */
  getMaxWidth() {
- return this._container.style.maxWidth;
+ return this._container && this._container.style.maxWidth;
  }
 
  /**
@@ -356,7 +356,9 @@ export default class Popup extends Evented {
  * popup.addClassName('some-class')
  */
  addClassName(className: string) {
- this._container.classList.add(className);
+ if (this._container) {
+ this._container.classList.add(className);
+ }
  }
 
  /**
@@ -369,7 +371,9 @@ export default class Popup extends Evented {
  * popup.removeClassName('some-class')
  */
  removeClassName(className: string) {
- this._container.classList.remove(className);
+ if (this._container) {
+ this._container.classList.remove(className);
+ }
  }
 
  /**
@@ -384,7 +388,9 @@ export default class Popup extends Evented {
  * popup.toggleClassName('toggleClass')
  */
  toggleClassName(className: string) {
- return this._container.classList.toggle(className);
+ if (this._container) {
+ return this._container.classList.toggle(className);
+ }
  }
 
  _createContent() {