Fix tagged builds on CircleCI (#3225)

* Fix circle tagged build * improve docs
mapbox · Sep 19, 2016 · 620c9b1 · 620c9b1
1 parent 7929862
commit 620c9b1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/ci/dependencies.sh b/ci/dependencies.sh
@@ -13,6 +13,6 @@ else
     source ./nvm/nvm.sh && nvm use ${NODE_VERSION} && npm install && npm ls
 fi
 
-if [ "$CIRCLE_BRANCH" == "master" ] || [ -z "$CIRCLE_TAG" ]; then
+if [ "$CIRCLE_BRANCH" == "master" ] || [ -n "$CIRCLE_TAG" ]; then
     pip install --user --upgrade awscli
 fi
diff --git a/ci/test.sh b/ci/test.sh
@@ -3,7 +3,7 @@
 source ./nvm/nvm.sh
 nvm use ${NODE_VERSION}
 
-set -eu
+set -e
 set -o pipefail
 
 # add npm packages to $PATH
@@ -27,7 +27,10 @@ npm run test-cov
 
 # send coverage report to coveralls
 nyc report --reporter=lcov
-(node ./node_modules/coveralls/bin/coveralls.js < ./coverage/lcov.info) || true
+# this code works around a Coveralls / CircleCI bug triggered by tagged builds
+if [ -z "$CIRCLE_TAG" ]; then
+    (node ./node_modules/coveralls/bin/coveralls.js < ./coverage/lcov.info) || true
+fi
 
 # upload benchmarks
 if [ "$CIRCLE_BRANCH" == "master" ]; then