Fix z-fighting of translucent fills

mapbox · Aug 30, 2017 · 79585ce · 79585ce
1 parent 45fde16
commit 79585ce
Show file tree

Hide file tree

Showing 3 changed files with 89 additions and 0 deletions.
diff --git a/src/render/draw_fill.js b/src/render/draw_fill.js
@@ -26,6 +26,7 @@ function drawFill(painter: Painter, sourceCache: SourceCache, layer: FillStyleLa
         // Once we switch to earcut drawing we can pull most of the WebGL setup
         // outside of this coords loop.
         painter.setDepthSublayer(1);
+        painter.depthMask(painter.isOpaquePass);
         drawFillTiles(painter, sourceCache, layer, coords, drawFillTile);
     }
 

diff --git a/test/integration/render-tests/regressions/mapbox-gl-js#3320/expected.png b/test/integration/render-tests/regressions/mapbox-gl-js#3320/expected.png
diff --git a/test/integration/render-tests/regressions/mapbox-gl-js#3320/style.json b/test/integration/render-tests/regressions/mapbox-gl-js#3320/style.json
@@ -0,0 +1,88 @@
+{
+  "version": 8,
+  "metadata": {
+    "test": {
+      "width": 64,
+      "height": 64
+    }
+  },
+  "pitch": 40,
+  "bearing": 20,
+  "sources": {
+    "geojson": {
+      "type": "geojson",
+      "data": {
+        "type": "GeometryCollection",
+        "geometries": [
+          {
+            "type": "Polygon",
+            "coordinates": [
+              [
+                [
+                  -20,
+                  -20
+                ],
+                [
+                  -20,
+                  20
+                ],
+                [
+                  20,
+                  20
+                ],
+                [
+                  20,
+                  -20
+                ],
+                [
+                  -20,
+                  -20
+                ]
+              ]
+            ]
+          },
+          {
+            "type": "Polygon",
+            "coordinates": [
+              [
+                [
+                  -25,
+                  -25
+                ],
+                [
+                  -25,
+                  25
+                ],
+                [
+                  25,
+                  25
+                ],
+                [
+                  25,
+                  -25
+                ],
+                [
+                  -25,
+                  -25
+                ]
+              ]
+            ]
+          }
+        ]
+      }
+    }
+  },
+  "sprite": "local://sprites/emerald",
+  "layers": [
+    {
+      "id": "fill",
+      "type": "fill",
+      "source": "geojson",
+      "paint": {
+        "fill-antialias": false,
+        "fill-color": "blue",
+        "fill-opacity": 0.5
+      }
+    }
+  ]
+}