Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label placement on the server #133

Closed
kkaefer opened this issue Oct 16, 2013 · 3 comments
Closed

Label placement on the server #133

kkaefer opened this issue Oct 16, 2013 · 3 comments

Comments

@kkaefer
Copy link
Contributor

kkaefer commented Oct 16, 2013

Since we already load the map stylesheet before delivering the tile, we can just as well do the label placement on the server in case this turns out to be expensive.

@ansis
Copy link
Contributor

ansis commented Nov 6, 2013

Currently, placement is slow in dense areas, and rotation collisions made it worse. But I think there is plenty that can still be optimized, and I'm optimistic about getting performance to the point where its reasonable. The perceived slowness could be largely solved by not waiting for text placement to render other features.

Doing label placement on the server would mean redownloading data when font sizes change. Also, in the further future, something like iD would need placement in the client so it can handle changing data.

@kkaefer do you think its worth working on improving this? Or do you think placement on the server is inevitable and we should just skip straight to that?

@kkaefer
Copy link
Contributor Author

kkaefer commented Nov 7, 2013

Nope, I see label placement on the server as a last resort. We should try hard to do this on the client.

@ansis
Copy link
Contributor

ansis commented Nov 20, 2013

Closing. Client placement needs more work seems doable.

@ansis ansis closed this as completed Nov 20, 2013
bensleveritt pushed a commit to bensleveritt/mapbox-gl-js that referenced this issue Oct 24, 2016
Common Interface for sub controls and one store - fixes mapbox#148, fixes mapbox#149, fixes mapbox#137, fixes mapbox#133, fixes mapbox#104, fixes mapbox#94, fixes mapbox#89, fixes mapbox#144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants