Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove data-driven styling features from the v8 branch #1406

Closed
lucaswoj opened this issue Aug 4, 2015 · 3 comments
Closed

Remove data-driven styling features from the v8 branch #1406

lucaswoj opened this issue Aug 4, 2015 · 3 comments
Assignees
@lucaswoj

Comments

@lucaswoj
Copy link
Contributor

lucaswoj commented Aug 4, 2015

What is involved here? Unless #1336 becomes a huge blocker, we can probably leave some parts of data-driven styling in v8, given that gl-style-spec will reject any use of data-driven styling functions.

Ref mapbox/mapbox-gl-style-spec#322
@lucaswoj lucaswoj self-assigned this Aug 4, 2015
@lucaswoj lucaswoj mentioned this issue Aug 4, 2015
Closed
@jfirebaugh
Copy link
Contributor

I don't want to take on the performance risk of #1336 right now. Lets rewind the v8 branch to 83b3b57 or so and then cherry pick any subsequent fixes that were not related to DDS.

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Aug 5, 2015

Fair. I'll work through that tomorrow.

If we are going that route, then we might as well revert to mapbox-gl-function 1.0.0 at the same time. (re: mapbox/mapbox-gl-function#8)

@jfirebaugh
Copy link
Contributor

This is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucaswoj lucaswoj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfirebaugh @lucaswoj