Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for old-style function syntax #8

Closed
wants to merge 2 commits into from
Closed

Conversation

lucaswoj
Copy link

@lucaswoj lucaswoj commented Aug 4, 2015

Changing the API in GL JS was a big pain. Instead of reverting outright, I added seamless support for the old-style syntax. There’s a little hack to get around the lack of a proper distinction between “piecewise” and “continuous” functions but it shouldn’t be an issue for v8.

cc @jfirebaugh

Related to mapbox/mapbox-gl-js#1406

@jfirebaugh
Copy link
Contributor

Can't we just not make any changes here and revert to using v1.0.0 in mapbox-gl-js?

@lucaswoj
Copy link
Author

lucaswoj commented Aug 4, 2015

@jfirebaugh That would be possible but more work because the interface of this module has changed significantly.

@lucaswoj
Copy link
Author

lucaswoj commented Aug 4, 2015

(Also, its nice to battle-test this code a little)

@lucaswoj
Copy link
Author

Closed in favor of mapbox/mapbox-gl-js#1406

@lucaswoj lucaswoj closed this Aug 24, 2015
@lucaswoj lucaswoj deleted the v8-old-style branch January 4, 2016 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants