Icons jumping around

[nickidlugash]

[nickidlugash]

This does not appear to be an issue for retina.

[nickidlugash]

This does not appear to be an issue for retina.

I was wrong; it's an issue for retina, too.

[ansis]

Is the gif of one long zoom? or many short zooms?

[bhousel]

This looks a lot like mapbox/mapbox-gl-native#2230

[nickidlugash]

Is the gif of one long zoom? or many short zooms?

@ansis @bhousel Sorry, I missed this question while I was on vacation. I think it was many short zooms, but I just tested it again now and the jumping currently still happens either way.

[bhousel]

I get this on many short zooms. It's barely noticeable on retina, but even just zooming by one click on the mousewheel, it seems like the points are placed, then the urlhash updates, and the points jump a little bit.

Maybe after zooming, it renders, then update the url hash with dropped precision, and then fires off another render again to match what the hash says.

[incanus]

Related? mapbox/mapbox-gl-native#2230

[jfirebaugh]

This is the effect of rasterizing icons with linear interpolation while panning or zooming, and nearest neighbor when not. It's intended to keep the icons from jumping around while the animation is in progress, and make the look sharp when it is finished. Previously: #124.

[nickidlugash]

@jfirebaugh thanks for the background. So does this mean there is nothing practical we can do to fix this, other than to re-implement sdfs?

[jfirebaugh]

It's possible there's a bug with zooming, or we could tweak the behavior for zooming to make it look better.

[ansis]

I played around with several tweaks including having the delay be different whether it was a trackpad zoom or a mouse zoom but I don't think it helps overall. Increasing the delay makes really slow zooming smoother, but it makes the jump more obvious in all other cases. I think the current 200 is a good balance.