Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate need for "interactive" property on layers #1479

Closed
jfirebaugh opened this issue Sep 11, 2015 · 3 comments
Closed

eliminate need for "interactive" property on layers #1479

jfirebaugh opened this issue Sep 11, 2015 · 3 comments

Comments

@jfirebaugh
Copy link
Contributor

All layers should support featuresAt automatically. Behind the scenes the necessary datastructures should be built lazily, or however makes sense for performance.

Having a user-visible interactive layer property leaks implementation details to the API, is a big trap for users, and leads to convoluted examples like this.

@ansis
Copy link
Contributor

ansis commented Feb 12, 2016

I did some profiling and memory usage is fine when we remove interactive and make it enabled for all layers. and it could probably be optimized further.

The main task updating the style spec: mapbox/mapbox-gl-style-spec#418

Should we wait until the spec is changed and released or can we start ignoring it immediately?

@lucaswoj
Copy link
Contributor

I don't think we need to wait until the spec is changed.

That said, we do need to think carefully about this because it is a breaking change. Users who do not pass a layer parameter might expect only features from interactive: true layers to be returned.

@tmcw
Copy link
Contributor

tmcw commented Mar 24, 2016

🎉 🎉 🎉 this is excellent news thx @ansis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants