-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate zooming logic for trackpads #206
Comments
@kkaefer how big of a priority is this (how bad does the current approach feel on macbooks)? |
It's very awkward because there is no direct relation between the distance you move your finger and the zooming. |
Leaflet had the same discussion recently, and there was a similar heuristic proposed that seems to work — if the interval between the first two |
I'll leave this for someone else. My trackpad isn't good enough for this to be a problem I think the distance should be proportional, its just that its delayed. Making the duration of the transition proportional to the delta (or 0 if mousewheel is detected) could fix this: https://github.com/mapbox/llmr/blob/gl/js/ui/handlers.js#L49 Or feel free to disable easing until this is fixed, if its annoying |
Well, IMHO, the best would be to completely disable transitions for high-resolution trackpads; any sort of easing is weird because you get the feeling that it your touch doesn't immediately control the zoom level, or that the renderer is laggy. |
@kkaefer that's a pretty good idea. I'd love to see how that feels, and maybe try to use the same approach in Leaflet it it's good. |
Dang, Firefox uses double the scroll amount when the window is on a retina screen... |
@kkaefer via #179 (comment)
I'm seeing two ways the current mousewheel smoothing isn't ideal for trackpads:
The text was updated successfully, but these errors were encountered: