Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge multiple vertex or elements buffers #207

Closed
kkaefer opened this issue Dec 4, 2013 · 5 comments
Closed

Merge multiple vertex or elements buffers #207

kkaefer opened this issue Dec 4, 2013 · 5 comments
Assignees
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage

Comments

@kkaefer
Copy link
Member

kkaefer commented Dec 4, 2013

Currently, we create separate vertex/elements buffers when the vertex buffer reaches an item count of 65536. However, we could just continue in the same buffer and just reset the vertexAttribPointer to start indexing the buffer at a later position. That way, we'd have fewer buffer switches and fewer buffer transfer operations overall.

@mourner
Copy link
Member

mourner commented Jun 24, 2014

Did @ansis rewrite this recently?

@mourner mourner closed this as completed Jun 24, 2014
@jfirebaugh
Copy link
Contributor

This is still relevant, and should be changed to match what native does.

@jfirebaugh jfirebaugh reopened this Oct 21, 2016
@jfirebaugh jfirebaugh self-assigned this Oct 21, 2016
bensleveritt pushed a commit to bensleveritt/mapbox-gl-js that referenced this issue Oct 24, 2016
Don't ignore dist/mapbox-gl-draw.js on npm publish
@kkaefer
Copy link
Member Author

kkaefer commented Oct 24, 2016

Not sure how relevant this ticket is given that we use VBOs in most situations anyway.

@jfirebaugh
Copy link
Contributor

I've implemented this and will have a PR pending #3439. Not needing to keep track of multiple array/buffer groups per bucket is a nice code simplification.

@kkaefer
Copy link
Member Author

kkaefer commented Oct 24, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

No branches or pull requests

3 participants