Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setAngle(center, angle) doesn't take center into account #258

Closed
mourner opened this issue Feb 5, 2014 · 2 comments
Closed

setAngle(center, angle) doesn't take center into account #258

mourner opened this issue Feb 5, 2014 · 2 comments

Comments

@mourner
Copy link
Member

mourner commented Feb 5, 2014

No description provided.

@incanus
Copy link
Contributor

incanus commented Feb 5, 2014

Can you clarify? I just did some work over on the native side that allows for rotation gestures to center on the gesture center vs. the map center:

mapbox/mapbox-gl-native@dbea793

@mourner
Copy link
Member Author

mourner commented Feb 5, 2014

@incanus that's excellent! It's just that the current llmr setAngle code doesn't use the argument in any way https://github.com/mapbox/llmr/blob/gl/js/ui/map.js#L207-L218

@mourner mourner closed this as completed May 5, 2014
mourner added a commit that referenced this issue May 7, 2014
@mourner
Add center arg to setAngle, center/offset to rotateTo, close #258
b6be343
bensleveritt pushed a commit to bensleveritt/mapbox-gl-js that referenced this issue Oct 24, 2016
@mcwhittemore
Merge pull request mapbox#258 from mapbox/fresh-start
1413372 
0.6.0-rc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@incanus @mourner