Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build/externally linkable llmr.js #261

Closed
3 tasks done
yhahn opened this issue Feb 5, 2014 · 9 comments
Closed
3 tasks done

Build/externally linkable llmr.js #261

yhahn opened this issue Feb 5, 2014 · 9 comments
Assignees
@yhahn

Comments

@yhahn
Copy link
Member

yhahn commented Feb 5, 2014

Per chat discussion:

  • bucket/destination for llmr builds
  • use travis (?) to write to this destination
  • have other projects/demos use this instead of their own copies
@ghost ghost assigned mourner Feb 5, 2014
@yhahn yhahn assigned yhahn and unassigned mourner Feb 5, 2014
@yhahn
Copy link
Member Author

yhahn commented Feb 5, 2014

Taking to start.

@yhahn
Copy link
Member Author

yhahn commented Feb 5, 2014

@mourner got this working in travis-build branch:

https://magnum.travis-ci.com/mapbox/llmr/jobs/3335172

Haven't segmented builds by branch/version/tag or anything like that yet. Would love your recommendation on that.

@yhahn
Copy link
Member Author

yhahn commented Feb 5, 2014

Going with ${TRAVIS_BRANCH} for now. We can get more sophisticated later.

@yhahn yhahn mentioned this issue Feb 5, 2014
Merged
@mourner
Copy link
Member

mourner commented Feb 5, 2014

Looks great! What's the public link to the built files?

@yhahn
Copy link
Member Author

yhahn commented Feb 5, 2014

https://mapbox.s3.amazonaws.com/llmr/master/llmr.js

@yhahn
Copy link
Member Author

yhahn commented Feb 5, 2014

#265

@yhahn yhahn closed this as completed Feb 5, 2014
@kkaefer
Copy link
Member

kkaefer commented Feb 6, 2014

Adding the source maps to this might be useful.

mourner added a commit that referenced this issue Feb 6, 2014
@mourner
upload dev build to Travis too, #261
62e8684
@mourner
Copy link
Member

mourner commented Feb 6, 2014

@kkaefer updated travis config to upload dev version with source maps as well (llmr-dev.js)

@kkaefer
Copy link
Member

kkaefer commented Feb 6, 2014

Cool, thanks!

lucaswoj pushed a commit that referenced this issue Jan 11, 2017
@jfirebaugh
Use vanilla JSON.stringify for format
ae01e02 
Fixes #261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yhahn yhahn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mourner @kkaefer @yhahn