Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug causing geometry outside tile (in buffer) to be drawn on large maps #2676

Closed
andrewharvey opened this issue Jun 6, 2016 · 1 comment · Fixed by #4636
Closed

Fix bug causing geometry outside tile (in buffer) to be drawn on large maps #2676

andrewharvey opened this issue Jun 6, 2016 · 1 comment · Fixed by #4636
Labels
bug 🐞

Comments

@andrewharvey
Copy link
Collaborator

andrewharvey commented Jun 6, 2016 •
edited
Loading

mapbox-gl-js version: 0.26.0

Steps to Trigger Behavior

  1. Create a large 4096x4096px map.

Demo: http://jsbin.com/foqawokoqe/edit?html,output

Expected Behavior

Shouldn't see these tile boundary lines.

Actual Behavior

I'm seeing tile borders on both GeoJSON and mapbox://styles/mapbox/streets-v8'.

selection_307

I've tried a bunch of different values for buffer (starting with the minimum 0, 1, 16, 128, ending with the maximum 512 and not setting it) all it does is move where the lines appear.
@dpieri
Copy link

dpieri commented Jun 7, 2016

FWIW I've noticed the same artifact on Mapbox GL Native (Android)

pasted image at 2016_05_10 10_37 pm

This was referenced Jul 14, 2016
Closed
Closed
@lucaswoj lucaswoj changed the title on large maps geometry outside tile (in buffer) is drawn on the map Fix bug causing geometry outside tile (in buffer) to be drawn on large maps Jul 29, 2016
@andrewharvey andrewharvey mentioned this issue Nov 3, 2016
Closed
@YenTheFirst YenTheFirst mentioned this issue Feb 22, 2017
Closed
mourner added a commit that referenced this issue Apr 24, 2017
@mourner
use 3 more bits for clipping mask ids
501671c 
Fixes #3517. Fixes #2676. Likely fixes #1679.
@mourner mourner mentioned this issue Apr 24, 2017
Merged
mourner added a commit that referenced this issue Apr 24, 2017
@mourner
use 3 more bits for clipping mask ids (#4636)
5653c78 
Fixes #3517. Fixes #2676. Likely fixes #1679.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use 3 more bits for clipping mask ids mapbox/mapbox-gl-js
3 participants
@andrewharvey @lucaswoj @dpieri