Worker.redoplacement throws AssertionError on Satellite Raster when pitched

[swratten]

mapbox-gl-js version 0.27.0:

Steps to Trigger Behavior

1. Go to Mapbox Satellite Example
2. Pitch map
3. Check console

Expected Behavior

Normal map experience without console full of error messages

Actual Behavior

Console full of assertion errors

[lucaswoj]

@lbud reports being able to reproduce this bug. It may be related to some other raster image regressions in the latest release.

[mourner]

I'm surprised it gets to the worker stage — raster tiles shouldn't be related to that code in any way.

[lbud]

@lbud reports being able to reproduce this bug. It may be related to some other raster image regressions in the latest release.

Right — video and image sources also hit this bug. For the sake of pulling together a quick proof of concept for #3580 I threw in the return statement if source type was undefined here. It looks like on both pitch and rotate the style's internal _redoPlacement is called, which attempts to redo placement on all source caches.

I don't know enough about the history of the source/source cache refactor to speak to what this looked like before/where we should break out of this codepath if a source is not vector or geojson. @mourner do you recall?

[mourner]

@lbud I don't recall touching the source cache code, but will take a look today.