Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full screen control should not be displayed on unsupported device #4786

Closed
ethan-ho opened this issue Jun 6, 2017 · 2 comments
Closed

Full screen control should not be displayed on unsupported device #4786

ethan-ho opened this issue Jun 6, 2017 · 2 comments
Labels
bug 🐞 good first issue

Comments

@ethan-ho
Copy link

ethan-ho commented Jun 6, 2017

mapbox-gl-js version: 0.37.0

Steps to Trigger Behavior

  1. Visit Fullscreen example on iOS device, I am using iPad
  2. Click the fullsceen button on the map

Expected Behavior

If fullscreen JavaScript API is not supported on current device, the button should not be added to the map instance, like the GeolocateControl currently does.

Actual Behavior

The button is appearing but do nothing.
stepankuzmin added a commit to stepankuzmin/mapbox-gl-js that referenced this issue Jun 15, 2017
@stepankuzmin
do not display fullscreen control on unsupported devices mapbox#4786
bd3891d
@stepankuzmin stepankuzmin mentioned this issue Jun 15, 2017
Merged
mollymerp pushed a commit that referenced this issue Jun 21, 2017
@stepankuzmin @mollymerp
do not display fullscreen control on unsupported devices (#4838)
7b803b6 
* do not display fullscreen control on unsupported devices #4786

* move className into class property #4838

* check for fullscreen support with fullscreenEnabled #4838

* remove extra mozFullScreenEnabled check #4838

* check that Fullscreen control gets added then fullscreen is enabled #4838
@mollymerp
Copy link
Contributor

closed by #4838

@jerrygarciame123
Copy link

jerrygarciame123 commented Jun 4, 2018 •
edited
Loading

What is the JS to check? I'd like to check before I add the button. Thanks, John

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ethan-ho @mollymerp @anandthakker @jerrygarciame123