Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raster prerendering seams #604

Closed
lbud opened this issue Jul 23, 2014 · 10 comments
Closed

Raster prerendering seams #604

lbud opened this issue Jul 23, 2014 · 10 comments
Labels

Comments

@lbud
Copy link
Contributor

lbud commented Jul 23, 2014

rasterize seamquest is apparently not over:

screen shot 2014-07-23 at 12 18 14 pm

@mourner
Copy link
Member

mourner commented Jul 23, 2014

This time it looks different...

@lbud
Copy link
Contributor Author

lbud commented Jul 23, 2014

@mourner this actually does look like something @ansis and I were seeing during the original seamquest, just thought we fixed it pretty quickly because some of the seams (?) (at least all of the seams we were looking at) disappeared, and they're still not around in the locations where they were before...

@mourner
Copy link
Member

mourner commented Jul 23, 2014

@lbud I don't know, on previous screenshots the seams were barely visible, while on this one there's a clear gap between tiles.

@lbud
Copy link
Contributor Author

lbud commented Jul 23, 2014

well...did some snooping around and checked out the commit that merged that branch (a632597) and sure enough, we have seams 😕 .
screen shot 2014-07-23 at 2 14 51 pm
They weren't showing up in all the places I was looking before and are weirdly hard to find, but they are certainly there -- I'll investigate some more

@lbud
Copy link
Contributor Author

lbud commented Jul 23, 2014

erm, happens on non-prerendered tiles as well (this is outdoors-v4)
screen shot 2014-07-23 at 2 22 10 pm

@mourner
Copy link
Member

mourner commented Jul 23, 2014

Hmm... How does outdoors look in native?

@lbud
Copy link
Contributor Author

lbud commented Jul 23, 2014

hMMmmm. Good thought -- also broken.

screen shot 2014-07-23 at 2 37 55 pm

@mourner
Copy link
Member

mourner commented Jul 23, 2014

Then it looks like a terrain data problem, @ajashton thoughts?

@ajashton
Copy link

There is an 8px buffer of redundant data around each 256px tile to allow for blurring, etc Mapnik. There are some hard edges every 4th tile that are side effects of the processing, but I don't see how gaps like this screenshot would be caused by the data.

@mourner mourner added this to the future milestone Jul 24, 2014
@lbud
Copy link
Contributor Author

lbud commented Aug 11, 2014

Closing this as a data issue (ticketed in terrain)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants