Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print console warning for maps that use RTL text without RTL text plugin #6136

Open
ChrisLoer opened this issue Feb 12, 2018 · 0 comments
Open
Assignees
Labels

Comments

@ChrisLoer
Copy link
Contributor

When we added the RTL text plugin, we wanted to make it have no overhead/configuration complexity for people who didn't need it, on the assumption that motivated users would find the plugin and turn it on. However, if a developer wants to make a map that uses local language labels around the world, they may not even realize that RTL text isn't displaying correctly.

As a stop-gap, I think we should just add a console warning whenever we render text that requires the RTL plugin and it's not enabled. The warning should be minimally disruptive/almost invisible to users, but a map developer is pretty likely to see it and it's an easily actionable error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants