[master ticket] Improve error handling

[ryanhamley]

Motivation

There are quite a few open tickets that deal with a need to improve error handling in GL JS. These fall into several categories ranging from adding more specific detail to existing errors to adding new errors to better style validation. The goal of this ticket is to summarize the existing issues into categories and drive discussion of general improvements and refactors to error handling.

Better Error Messages

• Add an error message for calling "GeoJSONSource#setData" for a style that doesn't exist Add an error message for calling "GeoJSONSource#setData" for a style that doesn't exist  #2602
• Validation errors for layer properties should include layer id Validation errors for layer properties should include layer id #4108
• Improve validation error messages relating to even/odd number of arguments Improve validation error messages relating to even/odd number of arguments  #6437
• instanceof errors in IE 11 instanceof errors in IE 11 #6733
• Provide more information about errors in mapbox Provide more information about errors in mapbox #9314

Better Error Handling

• isSourceLoaded returns error instead of false isSourceLoaded returns error instead of false #9430

Update Error Type

• Make error handling in style consistent Make error handling in style consistent #3879
• contextmenu events not captured on Chrome for Android contextmenu events not captured on Chrome for Android  #7136

Emit New Error

• Display better message + emit error when bad args are passed to map camera events Display better message + emit error when bad args are passed to map camera events #4385
• Do not handle video loading errors Do not handle video loading errors #5646
• Missing Mapbox access token for a Mapbox source does not trigger the map.on('error') event Missing Mapbox access token for a Mapbox source does not trigger the map.on('error') event #6528
• iOS Safari Console Error 'Unhandled Promise Rejection: AbortError: Fetch is aborted' iOS Safari Console Error 'Unhandled Promise Rejection: AbortError: Fetch is aborted' #8480
• Print console warning for maps that use RTL text without RTL text plugin Print console warning for maps that use RTL text without RTL text plugin #6136

Validation

• Color validation doesn't evaluate channel values Color validation doesn't evaluate channel values  #6467
• Display the value of layer.id on validation Display the value of layer.id on validation #8455
• Improve expression type checking error for "match" Improve expression type checking error for "match" #5220

Better Docs

• Clarify type validation error message for == expression Clarify type validation error message for == expression #6387

The below sections are TBD
NOTES:

• should all possible errors be routed through GL JS Error class?
• what are the performance concerns of try/catch blocks?
• would we have to wrap every conceivable browser call?

Design Alternatives

Design

Mock-Up

Concepts

Implementation