Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double clicking to zoom in breaks map dragging/panning in Edge #6740

Closed
GUI opened this issue May 25, 2018 · 1 comment · Fixed by #6743
Closed

Double clicking to zoom in breaks map dragging/panning in Edge #6740

GUI opened this issue May 25, 2018 · 1 comment · Fixed by #6743

Comments

@GUI
Copy link
Contributor

GUI commented May 25, 2018

mapbox-gl-js version: 0.45.0

browser: Edge 42.17134.1.0

Steps to Trigger Behavior

  1. Double click on the map to zoom in.
  2. Click and hold on the map and drag in an attempt to pan around.

Link to Demonstration

https://www.mapbox.com/mapbox-gl-js/example/simple-map/

Expected Behavior

That the map pans as it normally does when dragging it around.

Actual Behavior

Panning doesn't work. The map shifts by a few pixels, but then a "not allowed" icon (🚫) pops up above the cursor, and despite dragging the cursor around, the map does not actually pan.

If you single click on the map at this zoom level, then normal panning functionality is restored. This only seems to happens after double-clicking on the map to zoom in. If you zoom in by other means (scrolling or using zoom buttons if present on the map), then this doesn't happen.

In Edge 41, the behavior is mostly the same, although after trying to pan, the cursor also gets stuck in the the grabbing state (so the closed hand version of the icon) after tying to pan until you single click again. I'm not sure if that's relevant, but it seems like Edge is somehow getting mixed up about what state the drag behavior is in after double-clicking.

GUI added a commit to GUI/mapbox-gl-js that referenced this issue May 25, 2018
See mapbox#6740

Double-clicking on the map breaks panning in Edge and IE11. The issue is
that after double-clicking, Edge & IE perform a text selection within
the div, so then subsequent drag actions are trying to drag the
selection instead of dragging the map. This fixes it by disabling text
selection within the container.
@GUI
Copy link
Contributor Author

GUI commented May 25, 2018

I opened a PR which I think fixes this: #6743 The issue appears to be that Edge is performing a text selection on double-click, so subsequent drags after double-clicking are trying to drag the selection.

This issue also appears to affect IE11 (the behavior is subtly different, but the issue is basically the same).

jfirebaugh pushed a commit that referenced this issue May 25, 2018
See #6740

Double-clicking on the map breaks panning in Edge and IE11. The issue is
that after double-clicking, Edge & IE perform a text selection within
the div, so then subsequent drag actions are trying to drag the
selection instead of dragging the map. This fixes it by disabling text
selection within the container.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant