Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diacritic marks on certain glyph letters incorrectly placed #7195

Closed
ghost opened this issue Aug 24, 2018 · 2 comments · Fixed by #11269
Closed

Diacritic marks on certain glyph letters incorrectly placed #7195

ghost opened this issue Aug 24, 2018 · 2 comments · Fixed by #11269
Labels
bug 🐞 needs investigation 🔍 Issues that require further research (e.g. it's not clear whether it's GL JS or something else)

Comments

@ghost
Copy link

ghost commented Aug 24, 2018

mapbox-gl-js version: 0.48.0

browser: Electron 2.0.3/Chromium

Expected Behavior

It should appear like below:

Sít' Eetí G̱eeyí <--- notice the i's
(Rendu Inlet)

Actual Behavior

It appears like this:

screen shot 2018-08-24 at 12 08 15 pm

This place is a native place in SE Alaska written out in one of the native languages of that area. Most but not all diacritic marks are coming through fine but the i's stand out.

@mourner mourner added bug 🐞 needs investigation 🔍 Issues that require further research (e.g. it's not clear whether it's GL JS or something else) labels Sep 18, 2018
@ikphilip
Copy link

ikphilip commented Sep 25, 2018

I've also been able to reproduce this problem. Perhaps my demo might be illuminating.

I'm mostly interested in the Combining Macon Below (U+0331) and lower case g. My demo also has an example where a Combining Acute symbol (U+0301) is displayed incorrectly with a lower case i.

It would be useful for me to display the macron below the g without intercepting the descender. I am unsure why this occurs but it is isolated to the canvas rendering of the text.

https://jsfiddle.net/9L7opy1c/2/

@1ec5
Copy link
Contributor

1ec5 commented Nov 10, 2018

The Mapbox Fonts API conflates glyphs with codepoints, so each codepoint can have only one glyph, one advance, and one baseline. In #7195 (comment), this is a problem because the “i” glyph is narrower than most other base letters, while in #7195 (comment), the standard combining glyph can’t accommodate any character with descenders. #4009 would implement basic kerning support. #191 might also be relevant, since combining characters are more likely to come from fallback fonts in the font stack.

/cc @ChrisLoer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 needs investigation 🔍 Issues that require further research (e.g. it's not clear whether it's GL JS or something else)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants