-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom stop functions permit literal
expressions, which trigger font API 404 status code
#7387
Comments
It looks like your example is mixing the the old data-driven functions I think you could rewrite it to use either just the old style, or, preferably the new. I haven't tested these examples so I could be adding some other bug: Old:
New (using step expressions):
Did you write your expression in Studio? Did studio provide any sort of validation. I'm wondering what we can do to help people avoid this issue. |
Yes. We've patched a fix that makes this difficult to do in the UI, but the JSON editor is pretty fair game.
Yes, we validate property values configured in the JSON editor using the mapbox-gl-js validate_property script. However, you can see that it's not catching this error: I can implement a catch in Studio, but if I'm accurate in thinking the validate_property script should throw an error on this, I can submit the pull request into this repo directly. |
mapbox-gl-js version: 0.46.0
browser: Google Chrome v69.0.3497.100
Steps to Trigger Behavior
https://api.mapbox.com/fonts/v1/{username}/literal,{encoded_fonts}/{range}.pbf?access_token={token}
. It looks like theliteral
expression reference is making its way into the font request.Link to Demonstration
Expected Behavior
The
literal
expression reference should be removed before making the font API request.Actual Behavior
The font API request contains the
literal
expression reference.The text was updated successfully, but these errors were encountered: