current yarn.lock file is incompatible with node version 10.11.0

[booo]

mapbox-gl-js version: 999a8d9 (master)

browser: -

node.js version: v10.11.0

Steps to Trigger Behavior

1. cd /tmp
2. git clone https://github.com/mapbox/mapbox-gl-js
3. yarn install

Excerpt from yarn output

... error upath@1.0.4: The engine "node" is incompatible with this module. Expected version ">=4 <=9". Got "10.11.0" error Found incompatible module ...

Expected Behavior

Yarn install should run without errors on node.js v10.11.0

Actual Behavior

Yarn fails to run properly because of an outdated yarn.lock

Proposed Solution

Update the yarn.lock file with yarn upgrade. What's your policy on updating the yarn.lock file? I can prepare a pull request with an update if you like.

[ryanhamley]

Thanks for the report @booo We're working on it here #7519 Just investigating a couple of issues before merging it.

[ryanhamley]

Ah, this is actually two slightly different issues. The yarn.lock file is now updated to reflect the change to JSDOM, but that wasn't what was causing the The engine "node" is incompatible with this module error. There appears to be a dependency somewhere installing upath@1.0.4 which is incompatible with Node 10. This issue was fixed in v1.0.5 of upath but whatever package is using it hasn't updated. We can run yarn upgrade to update all of our packages which results in the huge yarn.lock diff we tried to avoid in #7519. In the meantime, yarn upgrade or yarn --ignore-engines install both produce the desired result.

[booo]

Yarn why upath should tell you by which package the upath is used.

As far as I understand the yarn upgrade documentation it should be possible to upgrade individual packages with e.g. yarn upgrade upath. See https://yarnpkg.com/lang/en/docs/cli/upgrade/

If you remove the first occurrence of upath in the yarn.lock file and run yarn install you get a minimal change to the yarn.lock file:

diff --git a/yarn.lock b/yarn.lock
index 2a764c96a..394bdc1ce 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -11949,12 +11949,7 @@ unzip-response@^2.0.1:
   resolved "https://registry.yarnpkg.com/unzip-response/-/unzip-response-2.0.1.tgz#d2f0f737d16b0615e72a6935ed04214572d56f97"
   integrity sha1-0vD3N9FrBhXnKmk17QQhRXLVb5c=
 
-upath@^1.0.0:
-  version "1.0.4"
-  resolved "https://registry.yarnpkg.com/upath/-/upath-1.0.4.tgz#ee2321ba0a786c50973db043a50b7bcba822361d"
-  integrity sha512-d4SJySNBXDaQp+DPrziv3xGS6w3d2Xt69FijJr86zMPBy23JEloMCEOUBBzuN7xCtjLCnmB9tI/z7SBCahHBOw==
-
-upath@^1.0.5:
+upath@^1.0.0, upath@^1.0.5:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/upath/-/upath-1.1.0.tgz#35256597e46a581db4793d0ce47fa9aebfc9fabd"
   integrity sha512-bzpH/oBhoS/QI/YtbkqCg6VEiPYjSZtrHQM6/QnJS6OL9pKUFLqb3aFh4Scvwm45+7iAgiMkLhSbaZxUqmrprw==