Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels slipping/cropping at tile bounds #757

Closed
peterqliu opened this issue Sep 26, 2014 · 22 comments · Fixed by #1886
Closed

Labels slipping/cropping at tile bounds #757

peterqliu opened this issue Sep 26, 2014 · 22 comments · Fixed by #1886
Assignees
@ansis
Labels
bug 🐞
Milestone
0.13

Comments

@peterqliu
Copy link
Contributor

As we pan in and out, labels tuck under other layers at certain fractional zoom levels. So far, I've only seen this happen with city labels.

EDIT: happens with all symbols.
@lbud
Copy link
Contributor

lbud commented Oct 10, 2014

This one slips under roads at exactly z8:
layerorder-gljs-zl8

@peterqliu peterqliu changed the title Layer ordering Label slippage Oct 10, 2014
@jfirebaugh
Copy link
Contributor

@peterqliu Can you supply a test case style please?

@peterqliu
Copy link
Contributor Author

@jfirebaugh Yup

@jfirebaugh
Copy link
Contributor

This originates with #688 and will be fixed by #193. In the meantime if you need to avoid it use "symbol-avoid-edges": true.

@tmcw tmcw mentioned this issue Nov 5, 2014
Closed
@fnicollet fnicollet mentioned this issue Dec 16, 2014
Closed
@jfirebaugh jfirebaugh modified the milestone: v0.6.0 Jan 22, 2015
@jfirebaugh jfirebaugh modified the milestone: v0.6.0 Feb 10, 2015
@ansis ansis mentioned this issue Apr 28, 2015
Closed
@peterqliu
Copy link
Contributor Author

(bump)

This continues to be one of the most conspicuous rendering bugs in gl-js. Would appreciate some prioritization here

@jfirebaugh
Copy link
Contributor

@peterqliu: No status change since #757 (comment) -- blocked by #193, which is blocked by #682, which is blocked by mapbox/mapnik-vector-tile#53.

@mourner
Copy link
Member

mourner commented May 1, 2015

@jfirebaugh last time I asked @ansis, he said layer-by-layer isn't blocked by tessellation anymore, with an active branch about it. :)

@peterqliu
Copy link
Contributor Author

Test case, if anyone still needs: https://www.mapbox.com/bites/00108/#15.26/40.7306/-73.9869

@ansis ansis mentioned this issue May 2, 2015
Closed
@peterqliu peterqliu mentioned this issue May 27, 2015
Closed
@1ec5 1ec5 mentioned this issue May 27, 2015
Closed
@jfirebaugh jfirebaugh added this to the 0.9 milestone Jun 11, 2015
@mourner mourner mentioned this issue Jun 17, 2015
Closed
@jfirebaugh jfirebaugh mentioned this issue Jun 24, 2015
Closed
@mourner mourner mentioned this issue Jul 6, 2015
Closed
@ansis ansis mentioned this issue Jul 8, 2015
Closed
@jfirebaugh jfirebaugh modified the milestone: 0.10 Aug 12, 2015
@jfirebaugh jfirebaugh added this to the 0.12 milestone Sep 10, 2015
@jfirebaugh jfirebaugh mentioned this issue Sep 17, 2015
Closed
@amyleew
Copy link

amyleew commented Sep 17, 2015

Another test case: label slippage from z3 - z4

label-slip

@fnicollet fnicollet mentioned this issue Oct 8, 2015
Closed
@lyzidiamond
Copy link
Contributor

tagging @mapbox/support for known issue

@samanpwbb
Copy link
Contributor

just noticed that setting text-allow-overlap to true seems to make this problem go away:

with text-allow-overlap:
screen shot 2015-11-03 at 4 14 45 pm
without text-allow-overlap:
175f96b6-8246-11e5-9e80-140685e378cb

@peterqliu
Copy link
Contributor Author

@samanpwbb interesting; have you run into issues with the text colliding with symbols, when you turn that on?

@samanpwbb
Copy link
Contributor

@peterqliu yes, but they're not so bad.

@samanpwbb
Copy link
Contributor

@peterqliu heh, how about this – I'm now seeing the reverse behavior:
screen shot 2015-11-03 at 6 39 20 pm
screen shot 2015-11-03 at 6 39 17 pm

@jfirebaugh
Copy link
Contributor

Status update here is that work is in progress to fix this issue in #1197, but is blocked on issues with our headless rendering test system.

@jfirebaugh jfirebaugh mentioned this issue Nov 16, 2015
Closed
@manuelroth manuelroth mentioned this issue Nov 16, 2015
Closed
@mourner mourner mentioned this issue Nov 26, 2015
Closed
@samanpwbb samanpwbb mentioned this issue Dec 8, 2015
Closed
@lucaswoj
Copy link
Contributor

lucaswoj commented Dec 8, 2015

State update #2: fixing this bug is my highest priority right now and work is progressing in #1727. We are pushing hard to fix the underlying problems with our headless rendering test system.

@Rachine
Copy link

Rachine commented Dec 10, 2015

Hey, thank you to put priority on this one, have the same problem here!

@lucaswoj lucaswoj mentioned this issue Dec 12, 2015
Closed
1 task
@peterqliu peterqliu mentioned this issue Jan 3, 2016
Closed
ansis added a commit that referenced this issue Jan 5, 2016
@ansis
implement layer-by-layer rendering
002c690 
This makes rendering more similar to -native.

All layers are drawn in two passes: opaque and then transparent. Tile
clip ids are drawn to the stencil at the same time to allow for fast
switching between tiles. The depth buffer is used to drop fragments
below opaque fills.

fixes #757

Unlike -native, only the last 5 bits of the stencil buffer are used for
storing clip ids. The first 3 bits are still used for rendering
polygons.
@ansis ansis mentioned this issue Jan 5, 2016
Merged
@ansis ansis removed the in progress label Jan 5, 2016
@samanpwbb
Copy link
Contributor

🎆

@peterqliu
Copy link
Contributor Author

:O :O :O 🎉 💃

@lucaswoj
Copy link
Contributor

lucaswoj commented Jan 5, 2016

@ansis is back in town, ladies and gentleman 😄

@planemad
Copy link

planemad commented Jan 5, 2016

🚀 🚀 🚀 🚀 🚀

@manuelroth
Copy link

Great work, really nice to see this fixed. Looking forward to the next release.

@jfirebaugh jfirebaugh mentioned this issue Jan 26, 2016
Closed
lucaswoj pushed a commit that referenced this issue Dec 13, 2016
@ansis
implement layer-by-layer rendering
7167111 
This makes rendering more similar to -native.

All layers are drawn in two passes: opaque and then transparent. Tile
clip ids are drawn to the stencil at the same time to allow for fast
switching between tiles. The depth buffer is used to drop fragments
below opaque fills.

fixes #757

Unlike -native, only the last 5 bits of the stencil buffer are used for
storing clip ids. The first 3 bits are still used for rendering
polygons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ansis ansis

Labels
bug 🐞
Projects
None yet
Milestone
0.13