Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial bounds resets map's pitch to 0 #7597

Closed
pathmapper opened this issue Nov 17, 2018 · 2 comments
Closed

Initial bounds resets map's pitch to 0 #7597

pathmapper opened this issue Nov 17, 2018 · 2 comments
Labels
bug 🐞

Comments

@pathmapper
Copy link
Contributor

mapbox-gl-js version: v0.51.0

Question

Initial bounds added in #5518 resets the map's pitch (jsbin), is this expected behavior?

Asking because map.fitBounds preserves the pitch (jsbin) and it isn't documented that bounds resets it.

Links to related documentation

https://www.mapbox.com/mapbox-gl-js/api/#map

https://www.mapbox.com/mapbox-gl-js/api/#map#fitbounds
@pathmapper pathmapper changed the title Initial bounds resets maps pitch to 0 Initial bounds resets map's pitch to 0 Nov 17, 2018
@mourner
Copy link
Member

mourner commented Nov 21, 2018

This looks like an oversight in #5518. @stepankuzmin would you mind submitting a fix? Should a small change.

stepankuzmin added a commit to stepankuzmin/mapbox-gl-js that referenced this issue Nov 23, 2018
@stepankuzmin
fix: initial bounds resets map's pitch to 0 mapbox#7597
61156f8
@stepankuzmin stepankuzmin mentioned this issue Nov 23, 2018
Merged
@stepankuzmin
Copy link
Contributor

Sorry for the late response, fixed in #7617

mourner pushed a commit that referenced this issue Nov 23, 2018
@stepankuzmin @mourner
fix: initial bounds resets map's pitch to 0 #7597 (#7617)
8f13dc3
@mourner mourner closed this as completed Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mourner @stepankuzmin @pathmapper