Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serialization error breaks pencil style #8832

Closed
ansis opened this issue Oct 3, 2019 · 0 comments · Fixed by #8833
Closed

serialization error breaks pencil style #8832

ansis opened this issue Oct 3, 2019 · 0 comments · Fixed by #8833
Labels
bug 🐞 release blocker ⛔

Comments

@ansis
Copy link
Contributor

ansis commented Oct 3, 2019 •
edited
Loading

mapbox-gl-js version: 1.4.0

browser: Chrome

Steps to Trigger Behavior

  1. open https://api.mapbox.com/styles/v1/mapbox/cjzoh882k2njo1crylb28iiz3.html?mapboxGLVersion=1.4.0&access_token=pk.eyJ1IjoibWFwYm94IiwiYSI6ImNpejY4M29iazA2Z2gycXA4N2pmbDZmangifQ.-g_vE53SD2WrJ6tFX7QHmA#11.22/37.7499/-122.5473

Link to Demonstration

https://www.mapbox.com/gallery/#pencil

Expected Behavior

Map renders.

Actual Behavior

Uncaught Error: can't serialize object of unregistered class
ansis added a commit that referenced this issue Oct 3, 2019
@ansis
fix #8832 broken fill pattern layers
cc60e18 
ResolvedImage was not registered for serialization. This registers it
and fixes a couple codegen'd files so that they generate properly.
@ansis ansis mentioned this issue Oct 3, 2019
Merged
4 tasks
ansis added a commit that referenced this issue Oct 3, 2019
@ansis
fix broken layers with pattern expressions (#8833)
b83e052 
 fix #8832 broken fill pattern layers

ResolvedImage was not registered for serialization. This registers it
and fixes a couple codegen'd files so that they generate properly.
ryanhamley pushed a commit that referenced this issue Oct 9, 2019
@ansis
fix broken layers with pattern expressions (#8833)
a64bfc0 
 fix #8832 broken fill pattern layers

ResolvedImage was not registered for serialization. This registers it
and fixes a couple codegen'd files so that they generate properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 release blocker ⛔
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix broken layers with pattern expressions mapbox/mapbox-gl-js
1 participant
@ansis