Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evented.listens to return false when no listener exists #10281

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

ryanhamley
Copy link
Contributor

@ryanhamley ryanhamley commented Jan 12, 2021

Launch Checklist

  • briefly describe the changes in this PR
    • This picks up Evented.prototype.listen(type) method return undefined #9985 which has no movement since September and no CLA signed
    • evented.listens is documented as returning false when no listener is available. instead it returns undefined. this ensures that false is always returned while also cleaning up some typos in the doc string
  • write tests for all new functionality
  • document any changes to public APIs
    • fixes listens so that it matches current documentation
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Ensure evented.listens returns 'false' when no listener is available</changelog>

@ryanhamley ryanhamley merged commit 2c9c1a6 into main Jan 12, 2021
@ryanhamley ryanhamley deleted the fix-evented-listen branch January 12, 2021 21:02
@karimnaaji karimnaaji added this to the v2.1.0 milestone Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants