Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tiny-sdf version for an RTL glyph width fix. #10328

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Bump tiny-sdf version for an RTL glyph width fix. #10328

merged 2 commits into from
Jan 26, 2021

Conversation

ChrisLoer
Copy link
Contributor

@ChrisLoer ChrisLoer commented Jan 26, 2021

mapbox/tiny-sdf#26 prevented crashes on characters from RTL scripts, but could still mis-calculate the glyph width, leading to cut off characters. Poking around in MDN, I realized that the canvas textAlign property allows us to force all text to be laid out with left-alignment, which gives us the results the algorithm was expecting in the first place. This PR updates gl-js to use the version of TinySDF fixed with mapbox/tiny-sdf#27.

Before
Screen Shot 2021-01-26 at 9 39 21

After
Screen Shot 2021-01-26 at 9 38 54

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog></changelog>

@karimnaaji @mourner

Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs yarn.lock update as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants