Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address feature state docs feedback #10356

Merged
merged 3 commits into from
Feb 9, 2021
Merged

Address feature state docs feedback #10356

merged 3 commits into from
Feb 9, 2021

Conversation

asheemmamoowala
Copy link
Contributor

@asheemmamoowala asheemmamoowala commented Feb 5, 2021

Turns out the PR feedback I left in #9559 (review) made the feature state docs harder to understand. This is an effort to be more clear what kind of value types can be used with feature state.

Little bonus - zeroes out lint errors 🧹
closes #10105.

src/ui/map.js Outdated Show resolved Hide resolved
Asheem Mamoowala and others added 2 commits February 8, 2021 16:10
Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com>
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asheemmamoowala asheemmamoowala merged commit a942154 into main Feb 9, 2021
@asheemmamoowala asheemmamoowala deleted the fix-10105 branch February 9, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document that setFeatureState needs numeric ids
2 participants