Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix abrupt jump with globe view + maxBounds after transition to mercator #12124

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Fix abrupt jump with globe view + maxBounds after transition to mercator #12124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8ecf11
globe: fix abrupt jump with maxBounds after transition to mercator
mourner Aug 1, 2022
a3facb6
add a note to setMaxBounds docs about mercator vs other
mourner Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/geo/transform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1617,7 +1617,7 @@ class Transform {
if (!this.center || !this.width || !this.height || this._constraining) return;

this._constraining = true;
const isGlobe = this.projection.name === 'globe';
const isGlobe = this.projection.name === 'globe' || this.mercatorFromTransition;

// alternate constraining for non-Mercator projections
if (this.projection.isReprojectedInTileSpace || isGlobe) {
Expand Down
3 changes: 3 additions & 0 deletions src/ui/map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,6 +824,9 @@ class Map extends Camera {
* as close as possible to the operation's request while still
* remaining within the bounds.
*
* For `mercator` projection, the viewport will be constrained to the bounds.
* For other projections such as `globe`, only the map center will be constrained.
*
* @param {LngLatBoundsLike | null | undefined} bounds The maximum bounds to set. If `null` or `undefined` is provided, the function removes the map's maximum bounds.
* @returns {Map} Returns itself to allow for method chaining.
* @example
Expand Down