Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of tiles with extent != 4096 #1955

Merged
merged 1 commit into from
Jan 20, 2016
Merged

Fix rendering of tiles with extent != 4096 #1955

merged 1 commit into from
Jan 20, 2016

Conversation

lucaswoj
Copy link
Contributor

fixes #1952

regression caused by #1886, as predicted

@lucaswoj
Copy link
Contributor Author

I still see a number of instances of the ✨ constant 4096 scattered around the codebase but rendering seems to be correct in all cases I can identify.

👀 @ansis @mourner

@lucaswoj lucaswoj force-pushed the extent-1952 branch 2 times, most recently from 3189ea1 to 52ee6ac Compare January 20, 2016 20:51
@ansis
Copy link
Contributor

ansis commented Jan 20, 2016

It would be good to remove more of the remaining 4096's. It looks like some of them will cause clipping, drouble-drawing and pattern-sizing issues. the instances in:

  • circle_bucket.js
  • symbol_bucket.js
  • draw_fill.js
  • get_anchors.js

I think some of the others should be removable too

@mikemorris
Copy link
Contributor

Would be great to get this ported to gl-native too, happy to lend a hand if you want to give it a shot @lucaswoj.

Refs mapbox/mapbox-gl-native#250

@lucaswoj
Copy link
Contributor Author

@mikemorris this feature was implemented by @tmcw in #1234, I'm just fixing a regression caused by layer-by-layer.

@lucaswoj
Copy link
Contributor Author

Good call @ansis. Fixing those exposed some bugs in test suite.

@lucaswoj lucaswoj force-pushed the extent-1952 branch 2 times, most recently from 9fff4ac to 344510e Compare January 20, 2016 22:41
@lucaswoj lucaswoj merged commit 8692a12 into master Jan 20, 2016
@lucaswoj lucaswoj deleted the extent-1952 branch January 20, 2016 23:05
@lucaswoj lucaswoj mentioned this pull request Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiles with non-standard extent are broken
3 participants