Significantly improve zoom performance #220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull in, zooming becomes significantly faster, especially noticeable when zooming out a lot. The code in
datasource.js
file was pretty inefficient. Here's the summary of changes:z
variable isn't used anywhere there), and it still didn't filter out tiles that have higher zoom that needed — this fix alone made a big differenceTile.fromID
calls where they could be avoidedindexOf
calls,utils.unique
, etc.) — now it uses objects (and difference can also be calculated much faster)