-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create standard benchmark interface #2231
Conversation
Looks good, I especially like capturing motivation and quality criteria in the README. Do you think browser-based benchmarks are the way to go? Would we ever want headless / pure node benchmarks? |
We should explore headless and pure node benchmarks (especially #1362). The bench interface was designed to accommodate use in headless and pure node environments. For this PR, sticking to browser environments makes the most sense because it is simple and most representative of real-world usage. |
dac9f84
to
547d68c
Compare
It would be good to document how access tokens can be set and provided Other than that, this looks good! |
One remaining task: I just realized that the env variables won't work for the debug page because it isn't run through browserify. I think it's time to combine the debug server and bench server into one. |
ce4796b
to
6d504f1
Compare
Alrightey. This is ready to 🚢. Since the last round of 👀 I
|
6d504f1
to
ad5346b
Compare
fixes #2007 |
Still needs a few minor ESLint fixes. |
ad5346b
to
cfa7673
Compare
Oops. I could've sworn I had fixed and pushed those. 👀? |
42df7d0
to
5216f63
Compare
fixes #954 |
5216f63
to
bbcc6bd
Compare
This pull request defines a standard benchmark interface.
Having a consistent interface for benchmarks allows us to use the same test runner and, in the future, collect benchmark results in an automated way.
I haven't yet moved the
fps
benchmark over to this new interface. Once I get some 👀 and 👍 on the spec I'll tackle that.cc @ansis @mourner @jfirebaugh