Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up "camera flyTo ascends" test #2259

Merged
merged 1 commit into from
Mar 11, 2016
Merged

Speed up "camera flyTo ascends" test #2259

merged 1 commit into from
Mar 11, 2016

Conversation

lucaswoj
Copy link
Contributor

This PR makes our unit tests 73% faster, from 19 seconds to 5 seconds.

fixes #2252

Before

$  time prova test/js/*/*.js -q

    990 passed assertions.


real    0m18.970s
user    0m4.120s
sys     0m0.623s

After

$  time prova test/js/*/*.js -q

    990 passed assertions.


real    0m5.051s
user    0m2.771s
sys     0m0.373s

cc @jfirebaugh @ansis @bhousel

@bhousel
Copy link
Contributor

bhousel commented Mar 11, 2016

Seems good to me.. There's no good reason to spend 10 seconds flying the camera around.

@lucaswoj lucaswoj merged commit b8d3e56 into master Mar 11, 2016
@lucaswoj lucaswoj deleted the ascends-2252 branch March 11, 2016 19:34
@lucaswoj
Copy link
Contributor Author

I'm gonna take an emoji response 👍 as a :shipit:

@lucaswoj lucaswoj mentioned this pull request Aug 29, 2016
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speed up or remove "Camera flyTo ascends" test
2 participants
@lucaswoj @bhousel