Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generated filenames consistent & explicit #3029

Merged
merged 2 commits into from
Aug 18, 2016
Merged

Make generated filenames consistent & explicit #3029

merged 2 commits into from
Aug 18, 2016

Conversation

lucaswoj
Copy link
Contributor

@lucaswoj lucaswoj commented Aug 18, 2016

As of this PR

  • debug pages reference /debug/access-token.js by absolute path to fix brokenhttp://localhost:9966/debug page
  • debug/access-token.js is browserified to debug/access-token-generated.js
  • bench/index.js is browserified to bench/index-generated.js
  • package.json scripts use long-form command line flags for readability

Todo

  • ignore *-generated.js files in eslint

cc @mourner

@mourner mourner merged commit 3ff8138 into master Aug 18, 2016
@mourner mourner deleted the generated branch August 18, 2016 19:32
@mourner
Copy link
Member

mourner commented Aug 18, 2016

Great! The ignore part is already done — that's what eslint --ignore-path .gitignore flag does, since generated files are in gitignore.

@lucaswoj
Copy link
Contributor Author

Ah! Makes sense. I think I was seeing eslint errors from the files after switching branches. Thanks for the 🚢.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants