Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation, add instructions for Typescript definitions. #3257

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Update documentation, add instructions for Typescript definitions. #3257

merged 1 commit into from
Sep 26, 2016

Conversation

filoxo
Copy link
Contributor

@filoxo filoxo commented Sep 26, 2016

The Typescript definitions were contributed to DefinitelyTyped (DefinitelyTyped/DefinitelyTyped#11386), and were then pushed to @types npm namespace.

This PR documents how to install the typings using typings as well as @types on npm for mapbox-gl-js.

Copy link
Contributor

@lucaswoj lucaswoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lucaswoj lucaswoj merged commit e0e3a67 into mapbox:master Sep 26, 2016
@filoxo
Copy link
Contributor Author

filoxo commented Sep 27, 2016

@lucaswoj glad I could contribute! Just curious though, it appears that 335a020 actually undoes the changes I made. Was that accidental?

@lucaswoj
Copy link
Contributor

335a020 retains the URL switch to DefinatelyTyped and removes the installation instructions. I would not like this documentation to be a source of truth about how to use the TypeScript tooling.

@filoxo
Copy link
Contributor Author

filoxo commented Sep 28, 2016

Fair enough 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants