Add alwaysVisible option to disable text collision #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe there's a better name for the option... |
|
It looks like the features are still inserted into the tree and will block other features (without alwaysVisible) layer. Is this intentional? |
|
@ansis yeah, pretty much — the main purpose is to disable the labels from hiding due to collision, but it's still nice not to collide other features with those. |
|
It seems a bit odd, but merging. |
ansis
added a commit
that referenced
this pull request
Mar 17, 2014
Add alwaysVisible option to disable text collision
bensleveritt
pushed a commit
to bensleveritt/mapbox-gl-js
that referenced
this pull request
Oct 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #315. @ansis what do you think?