add Geolocation PositionOptions as option to Geolocate Control (#3473) #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaswoj
approved these changes
Dec 5, 2016
There was a problem hiding this comment.
This looks good to me! I'll let the PR sit for < 1 day in case @jfirebaugh @tmcw @mollymerp @mourner have any feedback.
There are currently no tests for the Geolocation control, and I'm not sure how I would write tests without creating a mock Geolocation API.
Sorry about the lack of test infrastructure for these controls. 😞
|
Closing as this made it in with 2d10449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
Implementation for #3473, for example allowing developers to enableHighAccuracy.
There are currently no tests for the Geolocation control, and I'm not sure how I would write tests without creating a mock Geolocation API.