Code

WIP: Pitched label legibility#4682

Code

Closed

ChrisLoer wants to merge 41 commits intomastermapbox/mapbox-gl-js:masterfrom cloer_pitched_legibilitymapbox/mapbox-gl-js:cloer_pitched_legibilityCopy head branch name to clipboard

+4,593-206

Commits

Commits on May 1, 2017

• Introduce 'text/icon-pitch-scale' property which controls how

  Show description for a3f39be
  ChrisLoer

  committed
  a3f39be

  Copy full SHA for a3f39be

• Debugging changes for text-pitch-scale

  ChrisLoer

  committed
  c0a7232

  Copy full SHA for c0a7232

• 'text-pitch-scaling' calculations must be based on label anchors

  Show description for 0fa7793
  ChrisLoer

  committed
  0fa7793

  Copy full SHA for 0fa7793

• Fix "labelMinScale" logic in getGlyphQuads:

  Show description for 59e8768
  ChrisLoer

  committed
  59e8768

  Copy full SHA for 59e8768

• Make collision debug more legible for us colorblindies.

  ChrisLoer

  committed
  ffb62e1

  Copy full SHA for ffb62e1

• Avoid making collision boxes too narrow for pitched labels close to the viewport.

  ChrisLoer

  committed
  d16998a

  Copy full SHA for d16998a

• Make debug collision boxes take account of text-pitch-scale

  ChrisLoer

  committed
  de939ae

  Copy full SHA for de939ae

• Calculate line collision boxes over a wider range to account for label

  Show description for fe33752
  ChrisLoer

  committed
  fe33752

  Copy full SHA for fe33752

• Make pitched collision detection more conservative:

  Show description for eaa05d9
  ChrisLoer

  committed
  eaa05d9

  Copy full SHA for eaa05d9

• Fix comment: Tile.coord is a TileCoord, not a Coordinate

  ChrisLoer

  committed
  27fd05a

  Copy full SHA for 27fd05a

• Adjust collision tile scale range based on tile distance from camera.

  Show description for 3ca25e0
  ChrisLoer

  committed
  3ca25e0

  Copy full SHA for 3ca25e0

• CollisionTile#minimumPitchScaling needs to be serialized since it's used

  Show description for 0495a31
  ChrisLoer

  committed
  0495a31

  Copy full SHA for 0495a31

• 'max-camera-distance' style property allows selective hiding of labels

  Show description for f726efa
  ChrisLoer

  committed
  f726efa

  Copy full SHA for f726efa

• 'pitch-scale' -> 'pitch-scaling'

  ChrisLoer

  committed
  0e34868

  Copy full SHA for 0e34868

• Remove extra semicolon.

  ChrisLoer

  committed
  5921f93

  Copy full SHA for 5921f93

• Explain obscure difference between collision grid bounding boxes

  Show description for 1e33272
  ChrisLoer

  committed
  1e33272

  Copy full SHA for 1e33272

• Make render test summary failures searchable

  Show description for d382d55
  ChrisLoer

  committed
  d382d55

  Copy full SHA for d382d55

• Limit redoing placement for collisions to every 300ms.

  ChrisLoer

  committed
  894b071

  Copy full SHA for 894b071

• Update collision debug tests to new colors.

  ChrisLoer

  committed
  413fd99

  Copy full SHA for 413fd99

• Fix some tests: we create more line collision boxes now at the edge of

  Show description for 259ba28
  ChrisLoer

  committed
  259ba28

  Copy full SHA for 259ba28

• Fix tests: updated CollisionTile constructor

  ChrisLoer

  committed
  8fbadd2

  Copy full SHA for 8fbadd2

• Keep track of "maximum pitch scaling" as well as minimum pitch scaling

  Show description for b32aa68
  ChrisLoer

  committed
  b32aa68

  Copy full SHA for b32aa68

• min/max pitch scaling needs to be calculated over the whole tile

  Show description for 792f1c8
  ChrisLoer

  committed
  792f1c8

  Copy full SHA for 792f1c8

• Get debug collision boxes closer in sync with actual labels:

  Show description for 4bc4c26
  ChrisLoer

  committed
  4bc4c26

  Copy full SHA for 4bc4c26

• Icon perspective ratio should be based off of label anchor, not icon anchor.

  ChrisLoer

  committed
  efa1f6a

  Copy full SHA for efa1f6a

• Bring collision debug boxes into line with symbols that aren't added to buffers because their placementScale is above the maxScale for the collision tile.

  ChrisLoer

  committed
  20c5502

  Copy full SHA for 20c5502

• Eliminate major source of label flicker: "minimum pitch scale" setting

  Show description for f45f304
  ChrisLoer

  committed
  f45f304

  Copy full SHA for f45f304

• Update collision debug tests:

  Show description for be194a8
  ChrisLoer

  committed
  be194a8

  Copy full SHA for be194a8

• Fix query tests -- yStretch calculation wasn't correct on the render thread.

  ChrisLoer

  committed
  cf50802

  Copy full SHA for cf50802

• Fix unit tests and Flow errors.

  ChrisLoer

  committed
  7d759f7

  Copy full SHA for 7d759f7

Commits on May 2, 2017

• Fix 'symbol-avoid-edges', which relies on edge collision boxes being

  Show description for a8f0316
  ChrisLoer

  committed
  a8f0316

  Copy full SHA for a8f0316

• Temporarily fix tests by rolling back extended collision boxes for

  Show description for e98af15
  ChrisLoer

  committed
  e98af15

  Copy full SHA for e98af15

Commits on May 3, 2017

• Trying to make sense of how line collision boxes work.

  ChrisLoer

  committed
  5e06300

  Copy full SHA for 5e06300

• Make unit test for CollisionFeature account for pitch padding.

  ChrisLoer

  committed
  6e66906

  Copy full SHA for 6e66906

Commits on May 4, 2017

• Standardizing vertex shader precision on "highp" following discussion in:

  Show description for 47f02f1
  ChrisLoer

  committed
  47f02f1

  Copy full SHA for 47f02f1

• Replace conditional with step. Add infix spacing.

  ChrisLoer

  committed
  a8c7969

  Copy full SHA for a8c7969

• Pitch scaling for icon-rotation-alignment: map.

  ChrisLoer

  committed
  0a7e169

  Copy full SHA for 0a7e169

• Standardize order of cameraToCenter vs cameraToTile

  ChrisLoer

  committed
  f96db38

  Copy full SHA for f96db38

• More detailed explanatory comment for max-camera-distance property.

  ChrisLoer

  committed
  c293dbc

  Copy full SHA for c293dbc

• Only redo placement on pan operations if the map is tilted enough for

  Show description for f167af0
  ChrisLoer

  committed
  f167af0

  Copy full SHA for f167af0

• New approach to tilted curved labels with viewport pitch alignment:

  Show description for 5f02a52
  ChrisLoer

  committed
  5f02a52

  Copy full SHA for 5f02a52