Clarify docstrings for center param in Map to show coordinate ordering in LngLat.
#5042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar clarification is present in the docstring for [LngLat](https://github.com/mapbox/mapbox-gl-js/blob/f8bada03fa6bec448f9c8bfb6632467728493805/src/geo/lng_lat.js#L8)
Show that mapbox-gl uses [lng, lat] order
mollymerp
approved these changes
Jul 26, 2017
|
Thank you @karthikb351 🍪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar clarification is present in the docstring for LngLat
Looking at the examples, it isn't obvious to non-US users that the order passed to
centeris LngLat and not LatLng.Currently, you need to go 3 steps in the docs to find the explanation:
👇
👇
I believe a lot of people might be tripping up here, especially those coming from Leaflet or Mapbox.js
Mapbox has also made this clear in their guide to how web apps work
Launch Checklist