combine text and icon render types into symbol render type #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of through Placement
They were annoying to have logged all the time, and aren't something that can be fixed within this project.
Conflicts: debug/style-v3.json js/text/collision.js js/text/placement.js js/worker/worker.js
-allow-overlap -ignore-placement -rotation-alignment Also adds logic for requiring both text and icon, or just icon, or just text.
|
Conflicts: js/geometry/fillbucket.js js/geometry/linebucket.js js/render/drawsymbol.js js/worker/worker.js
|
I think this is good to merge now. What do you want to rebase? |
mourner
added a commit
that referenced
this pull request
Jul 7, 2014
combine text and icon render types into symbol render type
bensleveritt
pushed a commit
to bensleveritt/mapbox-gl-js
that referenced
this pull request
Oct 24, 2016
notes on where to look for name inspiration
lucaswoj
pushed a commit
that referenced
this pull request
Jan 11, 2017
stepankuzmin
pushed a commit
that referenced
this pull request
Jun 21, 2023
* Add icon-image-cross-fade into style spec * Parse secondary image variant name in image expressions * Load and render secondary image variants * Update test configuration * Update examples * Name primary image variant explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements mapbox/mapbox-gl-style-spec#67
fixes #494
fixes #491
fixes #454