Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parent tile retention for overzoomed tiles #5295

Merged
merged 1 commit into from
Sep 14, 2017
Merged

fix parent tile retention for overzoomed tiles #5295

merged 1 commit into from
Sep 14, 2017

Conversation

mollymerp
Copy link
Contributor

@mollymerp mollymerp commented Sep 14, 2017 •
edited
Loading

fix #5290

the scaledTo function wasn't returning the correct values for parents of overzoomed tiles resulting in loaded parents not being retained and a flicker.

cc @ryanbaumann

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

anandthakker
anandthakker approved these changes Sep 14, 2017
View reviewed changes
Copy link
Contributor

@anandthakker anandthakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. In native, there's a distinction between a CanonicalTileID and an OverscaledTileID, but here both are represented by TileCoord. I suppose we should eventually bring these two implementations into closer sync

@mollymerp
Copy link
Contributor Author

yep, exactly @anandthakker – I agree it would be useful to get TileCoord more in sync with native

@mollymerp mollymerp merged commit 3634d94 into master Sep 14, 2017
@mollymerp mollymerp deleted the retain-overzoomed-parents branch September 14, 2017 20:25
mollymerp added a commit that referenced this pull request Sep 18, 2017
@mollymerp
fix parent tile retention for overzoomed tiles (#5295)
8d9319b
@jmunowitch jmunowitch mentioned this pull request Sep 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandthakker anandthakker anandthakker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map re-requests over-zoomed tiles causing rendering flicker [0.40.0]
2 participants
@mollymerp @anandthakker