Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate functions #543

Merged
merged 5 commits into from
Jul 14, 2014
Merged

consolidate functions #543

merged 5 commits into from
Jul 14, 2014

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Jul 11, 2014

exponential, linear, and min function types are removed
stops function has a configurable exponential base
@mourner
Copy link
Member

mourner commented Jul 11, 2014

  • if we only have one function type now, lets drop the fn property, just {"stops": ...} should be enough
  • migrated stops have too much precision :)

Sorry, something went wrong.

@ansis
Copy link
Contributor Author

ansis commented Jul 11, 2014

I'm not sure if we should remove fn. If we add math operations or color operations we're going to need some way to determine whether a value is a function, and which type of function.
mapbox/mapbox-gl-style-spec#38
mapbox/mapbox-gl-style-spec#47

@mourner
Copy link
Member

mourner commented Jul 11, 2014

@ansis it can be determined based on keys present. If value.stops, then it's clearly a stops function.

@ansis
Copy link
Contributor Author

ansis commented Jul 12, 2014

@mourner ok, I'm having trouble figuring out how functions would be specified in the spec / validator without fn. Have any ideas?

@yhahn
Copy link
Member

yhahn commented Jul 12, 2014

Needs a bit of massaging on the spec/lint. Will poke this a bit more to make sure all is well.

@mourner
Copy link
Member

mourner commented Jul 14, 2014

@yhahn
Copy link
Member

yhahn commented Jul 14, 2014

Test fails are unrelated -- captured here: #550

yhahn added a commit that referenced this pull request Jul 14, 2014
@yhahn yhahn merged commit 18beb25 into dev-pages Jul 14, 2014
@yhahn yhahn deleted the consolidate-functions branch July 14, 2014 22:19
kkaefer added a commit that referenced this pull request Jul 17, 2014
this avoids a division by 0 and removes the need for awkward 1.01 hacks
refs #543 and mapbox/mapbox-gl-style-spec#96
kkaefer added a commit that referenced this pull request Jul 17, 2014
stepankuzmin pushed a commit that referenced this pull request Jun 21, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Add bvh implementation

* Add new intersection tests

* Add replacement source for landmark conflation

* Parse footprint from b3dm tiles

* Add landmark conflation

* Implement landmark conflation for fill extrusions

* Fix parsing of b3dm tiles without 'extensionUsed' field

* Add landmark-landmark conflation

* Add render tests

* Replace BVH with grid index

* review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants