-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disable() mid-drag (#2419) #5486
Conversation
Allows the user to call map.dragPan.disable() mid-drag. This enables draggable markers on mobile devices.
@krabbypattified thanks for your contribution! the tests are failing because of linting errors right now. you can fix this by running do you have a test case that you used to manually determine if this fix was working? I can investigate adding a unit test to test this fix as well. |
@mollymerp I've added a test for my code, but since there's no I've run |
Why is Flow doing this to me? |
Ooo @krabbypattified sorry for the delay here. What's happening is that since you're not explicitly ensuring that I belive you can get rid of this error by changing your condition on L111 from |
Thanks for the contribution @krabbypattified, and sorry that we weren't more responsive on this PR. It got overtaken by other event-related work, so I've opened an alternative fix for the issue in #6232. |
This code allows the user to call dragPan.disable() mid-drag.
This is intended as a fix for touch (mobile) devices.
It enables draggable markers on touch devices.