check if before layer exists #5679
Conversation
src/style/style.js
Outdated
| @@ -622,6 +622,10 @@ class Style extends Evented { | |||
| this._order.splice(index, 1); | |||
|
|
|||
| const newIndex = before ? this._order.indexOf(before) : this._order.length; | |||
| if (before && newIndex === -1) { | |||
| this.fire('error', { message: new Error(`Layer with id "${before}" does not exist on this map.`)}); | |||
There was a problem hiding this comment.
The key here should be error since you're passing an error object, not a message.
There was a problem hiding this comment.
Oh, I see it was mixed up in the original code.
There was a problem hiding this comment.
I think you're right, the key here should be error as well as here https://github.com/mapbox/mapbox-gl-js/pull/5679/files#diff-0fcf9ef37a1614185cad0dcbd5ec5529L571
There was a problem hiding this comment.
Shall I change it to a {error: ....}?
There was a problem hiding this comment.
yes please @jingsam and it would be great if you could change the it to {error: new Error... on line 571 as well. thank you!
|
Otherwise looks good! |
|
@jingsam did you want to fix up the JSDoc just a few lines above your change while you're at it? https://github.com/mapbox/mapbox-gl-js/blob/master/src/style/style.js#L601 |
|
fixed tests. but this seems odd: I prefer |
I think we should check if
beforelayer exists when move a layerLaunch Checklist