Fix collision detection perspective ratios #5913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Box and circle collision detection were using incorrectly inverted perspective ratios. [(1/(.5 + .5 * y/x) instead of (.5 + .5 * x/y)]. - Debug circles were using the same incorrect ratio (so they matched actual collision detection) - pixelsToTileUnits incorrectly included perspective ratio: it's used for measuring geometry, not text, so "scale" is relevant but "perspective ratio" isn't. 'collision-pitched-lines' exposed the behavior, but it was too complicated a test for us to be able to understand the problem.
ChrisLoer
force-pushed
the
fix-perspective-ratio
branch
from
a7a7823 to
8b7f390
Compare
|
Pushed a regression test that isolates the behavior from all the noise in the other collision render tests that are affected by this change. |
ansis
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #5911.
'collision-pitched-lines' exposed the behavior, but it was too complicated a test for us to be able to understand the problem.
I'll try to construct a regression test that clearly exercises the old vs. new behavior, but probably won't get around to it until the new year.
/cc @ansis @anandthakker @jfirebaugh