-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added mouseover event handler #6000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Maybe we could cut out the target looking part into a separate function to avoid duplication, but it's probably fine as it is.
Thanks @mourner! 🌱 🎉 Yeaa I was thinking about that as well, I decided to borrow it from |
added anchor option for marker
Revert "added anchor option for marker"
Apologies for the noise on this pull request! I was working on another issue and realized I had merged it to the same branch I was working on. |
No worries! BTW, you can force-push to the branch with the original commit hash instead of reverting. |
mmmh good to know! Will deff keep that in mind, thanks! |
Hi there,
I added an event handler for mouseover as requested in #3217. I ran the test suite and everything checks out, fairly new to contributing to open source and would love some feedback!
I've been really enjoying working and learning with mapbox on creative projects like printmaking and custom map vis. Thought it would be a fun learning experience to make some pr's! 🎊
Cheers!
-Jason
Launch Checklist