Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve ajax error messages #6032

Merged
merged 1 commit into from
Feb 14, 2018
Merged

improve ajax error messages #6032

merged 1 commit into from
Feb 14, 2018

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Jan 22, 2018

A failed GeoJSON load now logs AJAXError: Not Found (404): http://example.com/asdf.geojson instead of Error.

No error message was printed because of a lack of support for extending errors in Buble: bublejs/buble#40

Launch Checklist

  • briefly describe the changes in this PR
  • [N/A] write tests for all new functionality
  • [N/A] document any changes to public APIs
  • [N/A] post benchmark scores
  • manually test the debug page

@ansis ansis requested a review from lucaswoj January 22, 2018 19:13
A failed GeoJSON load now logs
`AJAXError: Not Found (404): http://example.com/asdf.geojson`
instead of
`Error`
@ansis ansis force-pushed the ajax-error-string branch from 0ab996d to c71e823 Compare February 8, 2018 20:10
Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! also tested this with #6126 and looks good 👍

@ansis ansis merged commit 11bcd3a into master Feb 14, 2018
@ansis ansis deleted the ajax-error-string branch February 14, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants