Support disable() mid drag or rotate gesture #6232
Merged
+374
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandthakker
approved these changes
Feb 26, 2018
| delete this._lastMoveEvent; | ||
| delete this._previousPos; | ||
| delete this._pos; | ||
| } |
There was a problem hiding this comment.
Just noting: because there's a state called 'active', I (briefly) found it confusing to have a method called _deactivate that doesn't affect this.state... but I can't think of any better names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
DragPanHandlerandDragRotateHandlercloser to a state machine based implementation, so that, when disabled, they can perform the appropriate actions in any state.These two handlers have four states:
disabled: The handler is disabled, and should not respond to any input.enabled: The handler is enabled but has not started receiving any input.pending: The handler has received amousedownortouchstartevent, but not a subsequentmoveevent.active: The handler has received amousedownortouchstartevent and at least one subsequentmoveevent.Disabling a handler in the
enabledstate doesn't generally require anything special. Disabling a handler in thependingstate requires unbinding some event listeners. Disabling a handler in theactivestate requires unbinding some event listeners, sending appropriate*endevents, and not triggering an inertial camera animation.Fixes #2419.