Revise special case handling for fill-outline-color #6242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior code in FillStyleLayer#recalculate handled the case where fill-outline-color was _currently_ undefined, but not the case where it was transitioning from an undefined value to a defined value. In order to handle that case, we must modify the special casing in DataDrivenProperty<T>#interpolate so that it returns a PossiblyEvaluatedPropertyValue containing undefined, rather than a bare undefined value. This makes the return value consistent with the "default value" for fill-outline-color (the one contained in PossiblyEvaluated#_values's prototype), and then both cases can be handled with one conditional in FillStyleLayer#recalculate.
lbud
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior code in
FillStyleLayer#recalculatehandled the case wherefill-outline-colorwas currently undefined, but not the case where it was transitioning from an undefined value to a defined value. In order to handle that case, we must modify the special casing inDataDrivenProperty<T>#interpolateso that it returns aPossiblyEvaluatedPropertyValuecontainingundefined, rather than a bareundefinedvalue. This makes the return value consistent with the "default value" forfill-outline-color(the one contained inPossiblyEvaluated#_values's prototype), and then both cases can be handled with one conditional inFillStyleLayer#recalculate.Fixes #6238.
Launch Checklist