Force touchstart, touchmove, and wheel listeners to be non-passive #6248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Mar 2, 2018
Yes, Chrome, yes WebKit: we really do intend to prevent the default scroll behavior for these events. This is the only way to silence the console warnings from Chrome and support iOS Safari 11.3+.
jfirebaugh
force-pushed
the
passive-agressive
branch
from
957b3b5 to
5355fc6
Compare
chrisvoll
added a commit
to seatgeek/mapbox-gl-js
that referenced
this pull request
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, Chrome, yes WebKit: we really do intend to prevent the default scroll behavior for these events.
This is the only way to silence the console warnings from Chrome and support iOS Safari 11.3+.
Fixes #6095.
Refs #3720.